Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dear Imgui to 1.79 with Docking Feature #2

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

AustinEast
Copy link
Contributor

This PR updates Dear Imgui to the Docking branch, based on 1.79 (the latest release). It also updates the HL bindings and Haxe API, with only minor breaking changes (ill list them below). I definitely understand if you aren't interested in merging in a feature that's technically still in testing - but it is very useful, it is togglable (it's turned off by default), and I can say from experience that it's fairly stable.

One thing to note - if accepted, this PR should be merged in after PR #1, since this branch was branched off of that (ive been using both features in my own codebase). Sorry about the inconvenience!

Changes:

  • Updates extensions/imgui to use the latest docking branch that has just been merged with 1.79 (specifically this commit)
  • Stops using RenderDrawListsFn in HL bindings (as it's been made obsolete in newer imgui versions), and updates the Render method to compensate
  • Adds dockSpace() method to Haxe API
  • Adds setConfigFlags() method to Haxe API. This is useful in general, but is also required to turn on the docking feature (like so: ImGui.setConfigFlags(ImGuiConfigFlags.DockingEnable);)
  • Breaking - changes ImGuiStyle.TabMinWidthForUnselectedCloseButton into ImGuiStyle.TabMinWidthForCloseButton
  • Breaking - changes ImGui. openPopupOnItemClick() return type from a Bool into a Void

@haddock7
Copy link
Owner

haddock7 commented Oct 21, 2020

Thanks again, I wish I had more high-quality pull requests like this one! I could definitely show it as a good example at my work :)
I have no problem merging the docking feature, as it has been around for 2 years now, so it should be considered stable.

Please make the tiny change in the first PR, and I'll merge them.

@haddock7 haddock7 merged commit e9893e3 into haddock7:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants