Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test code improvements #18

Merged
merged 6 commits into from
Dec 3, 2014
Merged

Test code improvements #18

merged 6 commits into from
Dec 3, 2014

Conversation

bpbond
Copy link
Contributor

@bpbond bpbond commented Nov 26, 2014

  1. Moved tests from inst/tests to tests/testthat
  2. Added new tests for file-related assertions
  3. Changed package so it imports tools. I think this is necessary for test code to exercise has_extension(), but tell me if there's a better way to do it.

Thanks, Ben

@@ -1,3 +1,5 @@
# Generated by roxygen2 (4.0.1): do not edit by hand
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to re-document man/*.Rd ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've re-generated all man/ docs and they're now included in this pull request, below.

@hadley
Copy link
Owner

hadley commented Dec 3, 2014

Thanks!

hadley added a commit that referenced this pull request Dec 3, 2014
@hadley hadley merged commit 3044b37 into hadley:master Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants