Fix pattern not ending in slash not matching directory #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @inkel! Can you rebase? I'll merge afterwards. |
I've found that when having an entry like `/foo/bar @foo` in the CODEOWNERS file the library properly reports `@foo` as the owner for `/foo/bar` and `/foo/bar/quux` but not for `/foo/bar/` (note the slash at the end). This PR adds tests for this case and fixes the regular expression to take this case into account.
inkel
force-pushed
the
inkel/fix-re-pattern-not-ending-slash
branch
from
04b82d2
to
4d9c7b1
Compare
|
Done! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that when having an entry like
/foo/bar @fooin the CODEOWNERS file the library properly reports@fooas the owner for/foo/barand/foo/bar/quuxbut not for/foo/bar/(note the slash at the end). This PR adds tests for this case and fixes the regular expression to take this case into account.