Unset LD_LIBRARY_PATH before openUrl

src/auto-login-service.cpp

@@ -27,7 +27,7 @@ void AutoLoginService::startAutoLogin(const QString& next_url)
                             ? account.getAbsoluteUrl(next_url)
                             : next_url;
     if (!account.isValid() || !account.isAtLeastVersion(4, 2, 0)) {
-        QDesktopServices::openUrl(absolute_url);
+        openUrl(absolute_url);
         return;
     }
 
@@ -59,7 +59,7 @@ void AutoLoginService::onGetLoginTokenSuccess(const QString& token)
     params.insert("next", req->nextUrl());
     url = includeQueryParams(url, params);
 
-    QDesktopServices::openUrl(url);
+    openUrl(url);
     req->deleteLater();
 }
 
@@ -69,6 +69,6 @@ void AutoLoginService::onGetLoginTokenFailed(const ApiError& error)
     qWarning("get login token failed: %s\n", error.toString().toUtf8().data());
     // server doesn't support client directly login, or other errors happened.
     // We open the server url directly in this case;
-    QDesktopServices::openUrl(req->account().getAbsoluteUrl(req->nextUrl()));
+    openUrl(req->account().getAbsoluteUrl(req->nextUrl()));
     req->deleteLater();
 }

src/filebrowser/file-browser-dialog.cpp

@@ -1628,7 +1628,7 @@ void FileBrowserDialog::onOpenLocalCacheFolder()
          seafApplet->warningBox(tr("Unable to create cache folder"), this);
          return;
      }
-     if (!QDesktopServices::openUrl(QUrl::fromLocalFile(folder)))
+     if (!openUrl(QUrl::fromLocalFile(folder)))
          seafApplet->warningBox(tr("Unable to open cache folder"), this);
 }
 

src/ui/init-vdrive-dialog.cpp

@@ -192,7 +192,7 @@ void InitVirtualDriveDialog::onDownloadRepoFailure(const ApiError& error)
 
 void InitVirtualDriveDialog::openVirtualDisk()
 {
-    QDesktopServices::openUrl(QUrl::fromLocalFile(default_repo_path_));
+    openUrl(QUrl::fromLocalFile(default_repo_path_));
     accept();
 }
 

src/ui/login-dialog.cpp

@@ -475,7 +475,7 @@ void LoginDialog::clientSSOLinkSuccess(const QString& link)
     QString sso_link(link);
 
     qInfo() << "open sso link in browser:" << sso_link;
-    QDesktopServices::openUrl(QUrl(sso_link));
+    openUrl(QUrl(sso_link));
 
     QRegularExpression re("/client-sso/([^/]+)");
     QRegularExpressionMatch match = re.match(sso_link);

src/ui/repo-tree-view.cpp

@@ -491,7 +491,7 @@ void RepoTreeView::showRepoDetail()
 void RepoTreeView::openLocalFolder()
 {
     LocalRepo repo = qvariant_cast<LocalRepo>(open_local_folder_action_->data());
-    QDesktopServices::openUrl(QUrl::fromLocalFile(repo.worktree));
+    openUrl(QUrl::fromLocalFile(repo.worktree));
 }
 
 void RepoTreeView::toggleRepoAutoSync()
@@ -557,7 +557,7 @@ void RepoTreeView::onItemDoubleClicked(const QModelIndex& index)
         const LocalRepo& local_repo = it->localRepo();
         if (local_repo.isValid()) {
             // open local folder for downloaded repo
-            QDesktopServices::openUrl(QUrl::fromLocalFile(local_repo.worktree));
+            openUrl(QUrl::fromLocalFile(local_repo.worktree));
         } else {
             // open seahub repo page for not downloaded repo
             FileBrowserManager::getInstance()->openOrActivateDialog(
@@ -573,7 +573,7 @@ void RepoTreeView::viewRepoOnWeb()
     if (account.isValid()) {
         // we adopt a new format of cloud view url from server version 4.2.0
         if (!account.isAtLeastVersion(4, 2, 0)) {
-            QDesktopServices::openUrl(account.getAbsoluteUrl("repo/" + selected_repo_.id));
+            openUrl(account.getAbsoluteUrl("repo/" + selected_repo_.id));
         } else {
             AutoLoginService::instance()->startAutoLogin("/library/" + selected_repo_.id + "/" + selected_repo_.name + "/");
         }

src/ui/starred-files-list-view.cpp

@@ -72,7 +72,7 @@ void StarredFilesListView::viewFileOnWeb()
             strurl = "lib/" + file.repo_id + "/file" + file.path;
         }
         QUrl url = account.getAbsoluteUrl(strurl);
-        QDesktopServices::openUrl(url);
+        openUrl(url);
     }
 }
 

src/ui/sync-errors-dialog.cpp

@@ -235,7 +235,7 @@ void SyncErrorsTableView::onItemDoubleClicked(const QModelIndex& index)
         LocalRepo repo;
         seafApplet->rpcClient()->getLocalRepo(error.repo_id, &repo);
         if (repo.isValid()) {
-            QDesktopServices::openUrl(QUrl::fromLocalFile(repo.worktree));
+            openUrl(QUrl::fromLocalFile(repo.worktree));
         }
     }
 }

src/ui/tray-icon.cpp

@@ -528,12 +528,12 @@ void SeafileTrayIcon::openHelp()
     } else {
         url = "https://help.seafile.com/syncing_client/install_sync/";
     }
-    QDesktopServices::openUrl(QUrl(url));
+    openUrl(QUrl(url));
 }
 
 void SeafileTrayIcon::openSeafileFolder()
 {
-    QDesktopServices::openUrl(QUrl::fromLocalFile(QFileInfo(seafApplet->configurator()->seafileDir()).path()));
+    openUrl(QUrl::fromLocalFile(QFileInfo(seafApplet->configurator()->seafileDir()).path()));
 }
 
 void SeafileTrayIcon::shellExtFix()
@@ -565,7 +565,7 @@ void SeafileTrayIcon::shellExtFix()
 void SeafileTrayIcon::openLogDirectory()
 {
     QString log_path = QDir(seafApplet->configurator()->ccnetDir()).absoluteFilePath("logs");
-    QDesktopServices::openUrl(QUrl::fromLocalFile(log_path));
+    openUrl(QUrl::fromLocalFile(log_path));
 }
 
 void SeafileTrayIcon::uploadLogDirectory()

src/utils/utils.cpp

@@ -123,7 +123,7 @@ QString defaultDownloadDir() {
 bool openInNativeExtension(const QString &path) {
 #if defined(Q_OS_WIN32)
     //call ShellExecute internally
-    return QDesktopServices::openUrl(QUrl::fromLocalFile(path));
+    return openUrl(QUrl::fromLocalFile(path));
 #elif defined(Q_OS_MAC)
     // mac's open program, it will fork to open the file in a subprocess
     // so we will wait for it to check whether it succeeds or not
@@ -177,7 +177,7 @@ bool showInGraphicalShell(const QString& path) {
     QProcess::execute("/usr/bin/osascript", scriptArgs);
     return true;
 #else
-    return QDesktopServices::openUrl(QUrl::fromLocalFile(QFileInfo(path).absolutePath()));
+    return openUrl(QUrl::fromLocalFile(QFileInfo(path).absolutePath()));
 #endif
 }
 
@@ -838,3 +838,18 @@ QString trimNULL(QString& s) {
     }
     return s;
 }
+
+bool openUrl(QUrl url) {
+#ifdef Q_OS_LINUX
+    // On linux openUrl will open the default browser via xgd-open, at this time LD_LIBRARY_PATH may affect xdg-open.
+    // We should unset this environment variable before openUrl, and reset it after openUrl.
+    QByteArray ldPath = qgetenv("LD_LIBRARY_PATH");
+    qunsetenv("LD_LIBRARY_PATH");
+#endif
+    QDesktopServices::openUrl(url);
+#ifdef Q_OS_LINUX
+    if (!ldPath.isEmpty()) {
+        qputenv("LD_LIBRARY_PATH", ldPath);
+    }
+#endif
+}

src/utils/utils.h

@@ -99,4 +99,6 @@ const QRect getScreenSize(int index);
 
 QString trimNULL(QString& s);
 
+bool openUrl(QUrl url);
+
 #endif