Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround rendering glitch in Firefox 47+ #1649

Closed
wants to merge 1 commit into from
Closed

Workaround rendering glitch in Firefox 47+ #1649

wants to merge 1 commit into from

Conversation

jackycute
Copy link

Including slides, overview been cutoff and text became blurry

2016-07-30 6 41 45

2016-07-30 6 41 45

Including slides, overview been cutoff and text became blurry
@potch
Copy link

potch commented Aug 18, 2016

Hey there- I'm from Mozilla and would like to help figure out what the bug is on our end. Do you have a reference URL where I can see slides with this issue? Also, what version of Firefox and OS are you seeing this in? I see you mention 47+.

@jackycute
Copy link
Author

jackycute commented Aug 19, 2016

Hi @potch, thanks for coming here.
For the blurry text, you could directly visit http://lab.hakim.se/reveal-js on Firefox.
I'm running on both WIndows 8.1 and Mac OS X 10.11 with Firefox 47+

But seems the overview and cutoff problem not showing in above link.
It might be the nest DOM and styles cause that problem, because I'm using plugin to covert markdown to slides.

Try this https://hackmd.io/p/slide-example
and disable below styles using DevTool and play with overview and change slides back and forth then you might be able to reproduce this issue.

.reveal .slides, .reveal .backgrounds, .reveal.overview {
    transform-style: preserve-3d;
}

.reveal .slides > section,
.reveal .slides > section > section {
    transform-style: flat;
}

Thanks!

@rajgoel
Copy link
Contributor

rajgoel commented Aug 19, 2016

@potch

Here's another example http://courses.telematique.eu/mathematics/?session=3

The glitch where the right part is cutoff appears when moving horizontally (left/right), vertical scroll (up/down) works. Using FF48.0 on Ubuntu 14.04

Please, note that I might be change transition mode to "none" in a few days because I will release the slides to students and don't want the glitch to be there then.

@hakimel
Copy link
Owner

hakimel commented Oct 5, 2016

Appreciate the PR. I had already switched to transform-style: flat for all non-3d transitions in the dev branch for a separate issue. The 3d transitions like concave and convex still used preserve-3d since they need it for the vertical 3d transitions to work.

I've revised this in 0b9233c so that preserve-3d is only used specifically for vertical stacks, and only when a 3d-transition is being used. This latest version is available to test on http://lab.hakim.se/reveal-js/

@jackycute
Copy link
Author

Not only the transition, the overview need to set that transfrom-style: flat.
I tried 0b9233c in FF 47, 48, 49 on OS X 10.11.6, the overview looks like below:

2016-10-05 8 56 13

@hakimel
Copy link
Owner

hakimel commented Oct 5, 2016

Gotcha. Not sure why but I'm not seeing that overview error in FF 48 on OS X 10.11.4. Anything special required to trigger it?

@jackycute
Copy link
Author

No, it's just very normal open and press.
I also tested FF48 on Windows 8.1, the overview looks good except it has been cutoff at the first load.

hakimel added a commit that referenced this pull request Oct 10, 2016
@hakimel
Copy link
Owner

hakimel commented Oct 10, 2016

Alright, was able to see the overview rendering issue in FF now too. Please give it a try at http://lab.hakim.se/reveal-js when you have a chance.

Let me know if you still see the problem and I'll reopen.

@hakimel hakimel closed this Oct 10, 2016
@jackycute
Copy link
Author

jackycute commented Oct 10, 2016

The cutoff on the first show up of overview in FF 49 on Windows persist.
2016-10-10 18 17 37
It might be a FF rendering bug or what.

OS X runs everything prefect! No glitch, no stretch, no cutoff, good job!
Thank you for making such awesome project!

@hakimel
Copy link
Owner

hakimel commented Oct 10, 2016

Damn. Thanks for testing. I was testing OS X too and things are working well there.

@hakimel hakimel reopened this Oct 10, 2016
KroArtem pushed a commit to KroArtem/UltraSparcT2Plus that referenced this pull request Nov 21, 2016
truist added a commit to truist/reveal.js that referenced this pull request Jan 11, 2017
* hakimel/master: (140 commits)
  fix unclosed code block
  3.4.0
  fragments inherit visibility to avoid conflicts with parent slide visibility
  don't show error message while iframe fades in hakimel#1577
  always use lowercase reveal.js
  Add note about head.js to readme.
  Enable passing options for parsing Markdown.
  Reduce required Node.js version to 4.0.0.
  Reduce required Node.js version to 4.0.0.
  update dependencies to work with latest node hakimel#1743
  correct copyright message to include contributors
  Better version of data-trim on code snippets
  Update README.md to reflect current defaults in js/reveal.js
  add pdf-ready event; dispatched when the presentation is laid out and ready to print
  Bump node engine in packages.json
  Don't remove slide-number in pdf view
  Hide slide number when in paper or pdf print view
  remove debug code
  fixes ff overview rendering bug hakimel#1649
  remove unused dom lookup
  ...
@hakimel
Copy link
Owner

hakimel commented Feb 1, 2017

Tested FF on Windows here and it seemed okay. Not sure under what exact circumstance the clipping in the screenshot above is occurring, but if anyone finds any new info please file that in a new issue.

@hakimel hakimel closed this Feb 1, 2017
@bnjmnt4n bnjmnt4n added the bug label Feb 2, 2017
SteveDesmond-ca pushed a commit to SteveDesmond-ca/presentations that referenced this pull request Apr 19, 2017
pm-nsimic pushed a commit to chriwu/ps-tec-2017 that referenced this pull request May 1, 2017
* resolves hakimel#1324 allow display property to be configured

- allow display property apply to current slide to be configured

* add 'npm build' script that launch grunt

* Allow switching off preview links

The data-preview-link=false tag can be used to switch off preview links

* Support sass extension for custom themes

* Shift `dependencies` to `devDependencies`.

The `reveal.js` npm module is typically installed to access the CSS/JS
assets for Reveal.js. For those that want to run the plugins, they would
clone the whole repository. Hence, it doesn’t make sense to include
those as `dependencies`, which will increase download times.

Closes hakimel#1734.

* Allow background images without protocols to have query hashes/parameters.

Closes hakimel#1603.

* hakimel#1770, resume playback for paused media.

* hakimel#1770, fixed function name.

* hakimel#1770, added second argument for setAttribute

* hakimel#1770, set 'data-paused-by-reveal' attribute only for the media elements, which are not already in paused state.

* support complex markdown

support <textarea data-template> `some code` </textarea>

* Remove 'history: true' from index.html

Readme says the default is 'history: false', so it may be surprising
for users - it's easy to miss the contradicting setting in index.html

* wait for in-slide video/audio to load before playing, reuse same autoplay logic for slide backgrounds

* prevent autoplaying backgrounds from playing if slide is hidden

* fix race condition by updating backgrounds after slide visibility

*  works with video, defaults to  (same as for images)

* remove unused argument

* make backgrounds (iframes) interactive when the foreground is empty

* 2017

* merge info links in index

* fix empty pages in pdf exports (closes hakimel#1804)

* additional fix for empty pages in pdf exports hakimel#1804

* adjust pdf margins instead of heights to fix hakimel#1804

* typo

* note about showNotes in PDF exports hakimel#1800

* fix markdown typo, update comment hakimel#1780

* recommend using textarea wrapper for inline markdown hakimel#1780

* make background videos work on ipad hakimel#1778

* improved fragment notes support hakimel#1636

* warning about cube/page being deprecated hakimel#1774

* adjust comment for display config value hakimel#1325

* added toggleHelp function 

this way a key can be given ability to toggleHelp on and off.  Previously Reveal.showHelp could open the help screen, but no way to close it.

* added override parameter to toggleHelp function

* update deserialize regex to work with decimals

* docs for hakimel#1816 and remove showHelp

* phantom export throws error if reveal.js isn't present

* fix overview rendering issues in latest chrome hakimel#1649

* allow configuration of which view slide number appears on - fixes hakimel#1791

* correct config name in README

* note about deploying multiplex server with now hakimel#1830

* tweaks to showSlideNumber config hakimel#1833

* avoid npe on iframe postMessage

* print-pdf using callback iso timer

Use window.callPhantom icw page. onCallback to wait for pdf-ready event.
From: http://stackoverflow.com/a/28925479/129269

* print-pdf layout slide contents to fit stretch elements

layout() and thereby layoutSlideContents() is never invoked
when isPrintingPdf() is true so stretch elements are not
sized correctly.
This is ensured now by invoking the layoutSlideContents
from SetupPDF(). There seems no need to scale down
like in other PR's is suggested.

* Fix video background autoplay on iOS

* add autoPlayMedia config option, overrides individual autoplay settings

* allow fullscreen for background iframes

* new cli and in-browser pdf printing compatible fix for hakimel#1804

* make pdf page height offset configurable

* replace cdn.mathjax.org with cdnjs

cdn.mathjax.org is shutting down: https://www.mathjax.org/cdn-shutting-down/

This changes the default MathJax URL in the math plugin, as well as
references in README.md and test/examples/math.html

* formatting

* formatting

* clarify meaning of getProgress() value

* expose getPastSlideCount() via public API

This can be used by plugins which are concerned with helping the
presenter with their pace.

* clarify getTotalSlides() returns the number of slides

* add new getSlides() API

This can be used by plugins which are concerned with helping the
presenter with their pace.

* Allow popup window access to Reveal API

* extract time display code into new _displayTime() function

This will allow us to reuse the display code for displaying
an additional pacing timer.

* use opacity for muted clock elements

This allows us to use different colours for different timers,
which will be useful when we add a pacing timer.

* don't mute minutes when hours is unmuted

* avoid deleting existing classes when muting time elements

and make muting work for negative values

* don't show negative signs inside minutes/seconds elements

* round decreasing timers to mirror increasing timers

* document clock and timer in speaker notes window

* optionally display pacing advice based on slide timings

Add an option to display advice on whether the current pace of the
presentation is on track for the right timing (shown as green), and if
not, whether the presenter should speed up (shown as red) or has the
luxury of slowing down (blue).

The pacing timer can be enabled by configuring by the `defaultTiming`
parameter in the `Reveal` configuration block, which specifies the
number of seconds per slide.  120 can be a reasonable rule of thumb.
Timings can also be given per slide `<section>` by setting the
`data-timing` attribute.  Both values are in numbers of seconds.

When the option is enabled, clicking on the timers will reset the timer
to the beginning of the current slide, i.e. as if pacing was perfectly
on track, not to zero as if the presentation had just begun.

* minor tweak for hakimel#1564

* 3.5.0

* * updated big picture slide
* added schema image
* added deployment texts

* * update big picture svg
* adjusted big picture styles
* moved authors and company slides to the end
*

* * added styles for codelistings
* tweaked dockerfile
* added kubernetes cheatsheet
* moved tldr slide to end of presentation

* * added version number to html source
* added config file for CircleCI integration
* added deploy.sh

* * updated status badge
* troubleshooting deploy script

* * bugfix as suggested in https://goo.gl/W1XnSk

* * changed circle badges in readme
* finetuning deploy.sh
* moved sha label to span inside presentation

* * optimized Dockerfile to leverage docker caching

* * added key ‘v’ to toggle display of GIT sha in upper right corner

* * added PS_VERSION_NUMBER to big picture slide
* shortened stateflow texts

* * removed unneeded files

* * added link to github project on tldr

* * changed port for k8-service

* wip

* * finetuning deployment

* debug

* * editorial finetuning

* * extended deploy script to update dyndns with public cluster ip address

* * added shell scripts for starting and stopping the kubernetes (k8) cluster on GCP
* moved it all to subfolder k8

* * huge commit. The best. No seriously, it’s way to big and it can easily serve as a bad example.

* * added seniority
* finetuning claims on last slide
* controls are now hidden

* * extended collaboration slide

* * added samples for collaboration

* * replaced slide bgnd by collage

* * modified collage
* swapped slide order
* added notes
* reduced size of leafs bgnd

* * tweakd tldr slide

* * replaced the bgnd image on the collaboration slide - new one has some effects applied

* * ignoring .vscode folder

* * added data-timing values for every slide
* extended readme section of the repo

* * changed the way how the schema image is built into the slide

* * windows millenium. and why you may never have heard of it
derheap pushed a commit to derheap/reveal.js that referenced this pull request Feb 22, 2018
derheap pushed a commit to derheap/reveal.js that referenced this pull request Feb 22, 2018
R0bes pushed a commit to R0bes/Terraform-Presentation that referenced this pull request Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants