Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for background-video for iPad by introducing controls on all mobile devices. #1778

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -921,7 +921,7 @@ Reveal.initialize({

Then:

1. Install [Node.js](http://nodejs.org/) (1.0.0 or later)
1. Install [Node.js](http://nodejs.org/) (4.0.0 or later)
2. Run ```npm install```
3. Run ```node plugin/notes-server```

Expand Down Expand Up @@ -1107,7 +1107,7 @@ The core of reveal.js is very easy to install. You'll simply need to download a

Some reveal.js features, like external Markdown and speaker notes, require that presentations run from a local web server. The following instructions will set up such a server as well as all of the development tasks needed to make edits to the reveal.js source code.

1. Install [Node.js](http://nodejs.org/) (1.0.0 or later)
1. Install [Node.js](http://nodejs.org/) (4.0.0 or later)

1. Clone the reveal.js repository
```sh
Expand Down
4 changes: 4 additions & 0 deletions js/reveal.js
Original file line number Diff line number Diff line change
Expand Up @@ -2939,6 +2939,10 @@
video.muted = true;
}

if( isMobileDevice ) {
video.controls = true;
}

// Support comma separated lists of video sources
backgroundVideo.split( ',' ).forEach( function( source ) {
video.innerHTML += '<source src="'+ source +'">';
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"url": "git://github.com/hakimel/reveal.js.git"
},
"engines": {
"node": "~6.9.1"
"node": ">=4.0.0"
},
"dependencies": {
"express": "~4.13.3",
Expand Down