-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for hash linked slideNumber #2133
Conversation
This was suggested before but decided against: #2067 |
Recommendations to proceed? |
I think it'd be best to make the 1-based indexing optional to avoid breaking existing content. If you can revise that I'd be happy to merge this in. Thanks! |
One based indexing is now optional (defaults to zero based for compatibility) |
Thanks for updating. One more thing, can you change the merge target of the PR to the 'dev' branch? That's the working branch, we merge dev into master when a new version goes out. |
There is still something preventing the incorporation of this change? |
@hakimel: If it's just the wrong target branch, you should be able to change that yourself: |
Merged to dev branch and resolved conflicts. |
Thanks for resolving the conflicts 🙌 |
Adding support for hash linked slideNumber
There are two changes here -
Make the hash slide numbering match the shown slide so that
slide.html#/3
is slide 3 and not slide 2.Added an href link to the slide number if shown to make it simple to share a link to a particular slide even when history is not enabled. This also makes it easy to lock to a particular slide when using auto refresh tools while developing.