Only show resume on pause if controls enabled #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Both changes make sense – thanks! The resume button was added because some people were accidentally triggering the pause mode and getting stuck without knowing how to disable it. |
|
Ah, yes of course. That makes sense. "Where the 🤬 did my presentation just go?" 🤪 |
This was referenced Apr 1, 2019
This was referenced Apr 6, 2020
R0bes
pushed a commit
to R0bes/Terraform-Presentation
that referenced
this pull request
Jun 7, 2021
…ntrols Only show resume on pause if controls enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hakimel ,
This is such an awesome project! Thank you for making it 👏
I really love the idea of the pause-mode.
I'm not a big fan of the "Resume presentation"-button though... 🤭
I tried figuring out why it was introduced, but I couldn't.
So in this PR I'm proposing two things:
config.controlsto control whether or not the button is shown.dom.pauseOverlaylisten for clicks and close when clicked.This is just one way you could approach this. You could also introduce a new config for the button, but I thought it made good sense to use the
controls.Let me know what you think.