Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease specificity of style resets #2248

Closed
wants to merge 1 commit into from

Conversation

heavywatal
Copy link

Leading .reveal has been removed from style resets at the top of reveal.scss. I hope this PR will be a first step to address the issue #1952.

@hakimel
Copy link
Owner

hakimel commented Oct 25, 2018

Thanks for the PR. I've addressed this in a slightly different way in 6abc6e0

By removing the .reveal prefix we're affecting styling of the page as a whole which might cause styling conflicts with the surround page. Because of that I think it's better to move the reset styles to a separate file so that you can easily leave them out if you want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants