Add mobileViewDistance config key #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfou
approved these changes
Oct 28, 2019
|
Looks great, thanks! |
hakimel
added a commit
that referenced
this pull request
Dec 9, 2019
This was referenced Jan 29, 2020
mstksg
pushed a commit
to mstksg/reveal.js
that referenced
this pull request
Mar 9, 2020
This was referenced Apr 6, 2020
R0bes
pushed a commit
to R0bes/Terraform-Presentation
that referenced
this pull request
Jun 7, 2021
…istance Add mobileViewDistance config key
R0bes
pushed a commit
to R0bes/Terraform-Presentation
that referenced
this pull request
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Reveal.js in a project where we only ever want to show 1 slide at a time, so we set
viewDistance: 1. On mobile devices however, this setting is overriden toviewDistance: 2which breaks our application.This PR adds a
mobileViewDistancekey which defaults to 2, as it was before, but can now be configured at will.