Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding won't unload for the new bundle format when regional prompter is enabled #258

Closed
cyber-meow opened this issue Oct 22, 2023 · 1 comment

Comments

@cyber-meow
Copy link

cyber-meow commented Oct 22, 2023

Describe the bug

A bundle format is recently added to the dev branch of webui: AUTOMATIC1111/stable-diffusion-webui#13568 (for an example file see https://civitai.com/models/173081/)
This can be regarded as a LoRA with multiples built-in embeddings and is particularly relevant for the case of pivotal tuning (training of both LoRAs and embeddings together): https://civitai.com/articles/2494/making-better-loras-with-pivotal-tuning

The normal behavior is that the embeddings are only loaded when the LoRA is used, and otherwise gets unloaded afterwards
image

Yet, when regional prompter is enabled, the embeddings are never unloaded. For example, I can get such warning which should only occur when embeddings already exist.
Screenshot from 2023-10-22 13-33-38

The embeddings continue to take effect even if I remove the lora. I guess this is related to how LoRA is loaded in regional prompter.

Environment
Web-UI version: dev commit 464fbcd9
SD Version: 1.5

Other Enabled Extensions
I can observe this behavior when only built-in extensions and regional prompter are enabled.

@hako-mikan
Copy link
Owner

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants