-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hexagon] - Build the hexagon_remote runtime using cmake #7659
Conversation
Somehow Halide_Runtime needs to have a dependency on halide_hexagon_host, right? It doesn't link to it, but building Halide_Runtime should bring halide_hexagon_host up to date, too. Maybe via |
It's also worth noting that this adds a build-time dependency to the Hexagon SDK. The README should be updated with instructions on how to do that. Naturally, our CI will need to either disable Hexagon (e.g. in GitHub Actions) or acquire the Hexagon SDK. |
For the parts that are cross-compiled with the Hexagon toolchain and then treated opaquely... I think those should be factored into a separate project, along with a toolchain file that points to the Hexagon clang compilers. It can be added to the primary build via |
@alexreinking - Thank you for your review. |
Superseded by #7671 |
This PR builds the hexagon_remote runtime using CMake. This integrates the build of the hexagon_remote runtime into the Halide build if
TARGET_HEXAGON
is true.src/runtime/hexagon_remote/bin
.host
,src
andv65
subdirectories are no longer present because their contents are unique and we wont really be storing binaries in the repository anymore anyway.Since CMake is such a challenge for cross-compilation, please let me know if my approach is the right one.