Avoid generating name collisions in CSE #7821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // introduce, we can save some time by only adding names that could | ||
| // plausibly collide. In the vast majority of cases, this check will | ||
| // result in the set being empty. | ||
| if (op->name.size() > 1 && |
There was a problem hiding this comment.
Mild suggestion: pull this out into is_temporary_name() and add a make_temporary_name() that is a wrapper for unique_name('t')?
steven-johnson
approved these changes
Aug 29, 2023
|
Looks like some hvx failures were injected recently, somehow, they are failing in all PRs... |
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Avoid generating name collisions in CSE Alternative to halide#7801 (See the discussion there) Fixes halide#4124 * Add missing test * Minor cleanup * clang-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #7801 (See the discussion there)
Fixes #4124