Enable emission of float16/32 casts on x86 #7837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vksnk
approved these changes
Sep 5, 2023
AngryLoki
reviewed
Sep 5, 2023
| @@ -638,14 +644,17 @@ int main(int argc, char **argv) { | |||
| { | |||
| Target("x86-32-linux"), | |||
| Target("x86-32-linux-sse41"), | |||
| Target("x86-64-linux-sse41-avx"), | |||
| Target("x86-64-linux-sse41-avx-avx2"), | |||
| // Always turn on f16c when using avx. Haswell had avx without f16c, | |||
There was a problem hiding this comment.
Actually, Haswell had F16C (together with newly-added AVX2+FMA). Even IvyBridge supported F16C (without AVX2 or FMA). Only SandyBridge was pure AVX.
There was a problem hiding this comment.
Oops, I had haswell and ivy bridge in the wrong order in my head. I'll fix the comment.
|
Failures unrelated. |
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Enable emission of float16/32 casts on x86 Fixes halide#7836 Fixes halide#4166 * Fix comment * Don't catch bfloat casts * Fix missing word in comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7836
Fixes #4166
These weren't enabled yet because the last time this code was touched, float16 wasn't a legal type in llvm on x86 (See https://bugs.llvm.org/show_bug.cgi?id=43065)