Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't deduce unreachability from predicated out of bounds stores #7874

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Don't deduce unreachability from predicated out of bounds stores #7874

merged 1 commit into from
Oct 4, 2023

Conversation

abadams
Copy link
Member

@abadams abadams commented Oct 3, 2023

Fixes #7873

TH3CHARLie
TH3CHARLie approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@TH3CHARLie TH3CHARLie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures are unrelated

@abadams
Copy link
Member Author

abadams commented Oct 4, 2023

Failures unrelated (Seems we have a riscv breakage with llvm 18, which I'll fix separately)

@abadams abadams merged commit c31e8f7 into main Oct 4, 2023
3 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Feb 2, 2024
Closed
ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
@abadams @ardier
Don't deduce unreachability from predicated out of bounds stores (hal…
18e7ba1 
…ide#7874)

Fixes halide#7873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TH3CHARLie TH3CHARLie TH3CHARLie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong results when PredicateStores is used in Func with definitions using RDoms
2 participants
@abadams @TH3CHARLie