Static analysis (MSVC) fixes for device_buffer_utils.h #7904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abadams
reviewed
Oct 18, 2023
src/runtime/device_buffer_utils.h
Outdated
| @@ -89,7 +93,7 @@ WEAK device_copy make_buffer_copy(const halide_buffer_t *src, bool src_host, | |||
| // Offset the src base pointer to the right point in its buffer. | |||
| c.src_begin = 0; | |||
| for (int i = 0; i < src->dimensions; i++) { | |||
| c.src_begin += (uint64_t)src->dim[i].stride * (dst->dim[i].min - src->dim[i].min); | |||
| c.src_begin += (uint64_t)src->dim[i].stride * (uint64_t)(dst->dim[i].min - src->dim[i].min); | |||
There was a problem hiding this comment.
Good point... Are strides allowed to be negative too (to move "backward", in order to represent bottom-left origin images and such)?
There was a problem hiding this comment.
I changed both casts to (int64_t) to be consistent with the other similar casts in the same file.
|
Build-bot failures appear to be unrelated. |
abadams
approved these changes
Oct 20, 2023
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Static analysis (MSVC) fixes for device_buffer_utils.h * clang-format happiness * signed integer cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preventing things like: