Stop interleaver from expanding the scope of letstmts #7908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the following code:
let a = b in
X
let a = c in
Y
If Stmt X successfully had stores interleaved, it was re-nesting it like
so:
let a = b in
X
let a = c in
Y
This introduces a shadowed variable 'a', which is illegal at this stage
of lowering.
Fixes #7906
Also some drive-by fixes to earlier tests that had debugging code left
in.
vksnk
approved these changes
Oct 19, 2023
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
In the following code:
let a = b in
X
let a = c in
Y
If Stmt X successfully had stores interleaved, it was re-nesting it like
so:
let a = b in
X
let a = c in
Y
This introduces a shadowed variable 'a', which is illegal at this stage
of lowering.
Fixes halide#7906
Also some drive-by fixes to earlier tests that had debugging code left
in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following code:
If Stmt X successfully had stores interleaved, we were re-nesting it like so:
This introduces a shadowed variable 'a', which is illegal at this stage of lowering.
Fixes #7906
Also some drive-by fixes to earlier tests that had debugging code left in.