Track likely values through lets in loop partitioning #7930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7929 Improves runtime of lens_blur app by ~20%
Now that we look through lets, we end up in more situations where both sides have a captured likely.
vksnk
reviewed
Nov 2, 2023
src/BoundaryConditions.cpp
Outdated
| clamp(likely(arg_var), min, min + extent - 1)); | ||
| likely(clamp(likely(arg_var), min, min + extent - 1))); | ||
|
|
||
| // We want loop partitioning to both cause the clamp to go away, and |
There was a problem hiding this comment.
This comment seems to be after the line it explains.
There was a problem hiding this comment.
Also, it would be great if the comment explained why two likely tags cause it to go away.
|
|
||
| namespace Halide { | ||
| namespace Internal { | ||
|
|
||
| /** Return true if an expression uses a likely tag that isn't captured | ||
| * by an enclosing Select, Min, or Max. */ | ||
| bool has_uncaptured_likely_tag(const Expr &e); | ||
| bool has_uncaptured_likely_tag(const Expr &e, const Scope<> &scope); |
There was a problem hiding this comment.
The comments need to be updated to say that the scope is for variables of lets which has likely tag in them.
|
ptal |
vksnk
approved these changes
Nov 16, 2023
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Track likely values through lets in loop partitioning Fixes halide#7929 Improves runtime of lens_blur app by ~20% * Add uncaptured likely tags to selects in boundary condition helpers Now that we look through lets, we end up in more situations where both sides have a captured likely. * Better comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7929
Improves runtime of lens_blur app by ~20%