Do some basic validation of Target Features (#7986) #7987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abadams
reviewed
Dec 6, 2023
src/Target.cpp
Outdated
| WasmSimd128, | ||
| WasmThreads, | ||
| }; | ||
| user_assert(!features_any_of(bad_features_x86)) << "At least os_entry of the features for " |
abadams
reviewed
Dec 8, 2023
src/Target.cpp
Outdated
| WasmSimd128, | ||
| WasmThreads, | ||
| }; | ||
| user_assert(!features_any_of(bad_features_x86)) << "At least one of the features for " |
There was a problem hiding this comment.
A small code change would take the guesswork out of handling this error:
for (Feature f : bad_features_x86) {
user_assert(!has_feature(f)) << "Target feature " << f ...
}
abadams
approved these changes
Dec 8, 2023
|
Looks like a merge issue with the new wasm feature |
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Do some basic validation of Target Features (halide#7986) * Update Target.cpp * Update Target.cpp * Fixes * Update Target.cpp * Improve error messaging. * format * Update Target.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.