Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stronger chain detection in LoopCarry pass #8016

Merged
merged 10 commits into from
Jan 9, 2024
Merged

Stronger chain detection in LoopCarry pass #8016

Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3055e2a
Stronger chain detection in LoopCarry
vksnk Jan 2, 2024
7ed555b
Make sure that types are the same
vksnk Jan 3, 2024
b71d889
Add a comment
vksnk Jan 3, 2024
7cfc0b0
Merge branch 'main' into vksnk/better-loop-carry
vksnk Jan 3, 2024
8540d8b
Run CSE before calling can_prove
vksnk Jan 4, 2024
1fceaa3
Test for loop carry
vksnk Jan 4, 2024
09e48f8
clang-tidy
vksnk Jan 4, 2024
8ba85a2
Add missing override
vksnk Jan 5, 2024
89c74af
Update comments
vksnk Jan 8, 2024
20d6b0f
Merge branch 'main' into vksnk/better-loop-carry
vksnk Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/LoopCarry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,11 +299,16 @@ class LoopCarryOverLoop : public IRMutator {
if (i == j) {
continue;
}
// can_prove is stronger than graph_equal, because it doesn't require index expressions to be
// exactly the same, but evalutate to the same value. We keep the graph_equal check, because
vksnk marked this conversation as resolved.
Show resolved Hide resolved
// it's faster and should be executed before the more expensive check.
if (loads[i][0]->name == loads[j][0]->name &&
next_indices[j].defined() &&
graph_equal(indices[i], next_indices[j]) &&
(graph_equal(indices[i], next_indices[j]) ||
((indices[i].type() == next_indices[j].type()) && can_prove(indices[i] == next_indices[j]))) &&
next_predicates[j].defined() &&
graph_equal(predicates[i], next_predicates[j])) {
(graph_equal(predicates[i], next_predicates[j]) ||
((predicates[i].type() == next_predicates[j].type()) && can_prove(predicates[i] == next_predicates[j])))) {
chains.push_back({j, i});
debug(3) << "Found carried value:\n"
<< i << ": -> " << Expr(loads[i][0]) << "\n"
Expand Down