Remove Introspection #8273
Merged
Remove Introspection #8273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introspection (to provide better error messages + automatic var/func/etc names) has always been kinda handy but kinda fragile, and with the evolution of the DWARF standard it's become broken for newer compilers. We don't have the bandwidth to fix it, and many large customers (e.g. Google) have never been able to rely on it, and given that it can cause crashes in some unusual situations (e.g. when embedded inside a Go app), it's time to say goodbye. Alas! Poor Introspection. I knew him, Horatio. A feature of infinite jest, of most excellent fancy. It hath borne me on his back a thousand times.
steven-johnson
added
the
release_notes
abadams
reviewed
Jun 7, 2024
src/Deserialization.cpp
Outdated
| @@ -1057,8 +1057,9 @@ Definition Deserializer::deserialize_definition(const Serialize::Definition *def | |||
| const std::vector<Specialization> specializations = | |||
| deserialize_vector<Serialize::Specialization, Specialization>(definition->specializations(), | |||
| &Deserializer::deserialize_specialization); | |||
| // Desaerialize and ignore this value. | |||
There was a problem hiding this comment.
it's a perfectly cromulent spaeling
|
Finally green, PTAL |
abadams
approved these changes
Jun 25, 2024
1 task
|
I think we should update the tutorials to add explicit naming now, and teach how to use stmt and conceptual stmt files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introspection (to provide better error messages + automatic var/func/etc names) has always been kinda handy but kinda fragile, and with the evolution of the DWARF standard it's become broken for newer compilers. We don't have the bandwidth to fix it, and many large customers (e.g. Google) have never been able to rely on it, and given that it can cause crashes in some unusual situations (e.g. when embedded inside a Go app), it's time to say goodbye.
Alas! Poor Introspection. I knew him, Horatio. A feature of infinite jest, of most excellent fancy. It hath borne me on his back a thousand times.