Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

[release-1.5] perf: optimize the layout of some forms on mobile #565

Merged
merged 1 commit into from
May 9, 2022
Merged

[release-1.5] perf: optimize the layout of some forms on mobile #565

merged 1 commit into from
May 9, 2022

Conversation

halo-dev-bot
Copy link

This is an automated cherry-pick of #564

/assign JohnNiang

@ruibaby
perf: optimize the layout of some forms on mobile
c4e653a 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@halo-dev-bot halo-dev-bot mentioned this pull request May 9, 2022
Merged
@f2c-ci-robot f2c-ci-robot bot requested a review from QuentinHsu May 9, 2022 06:14
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 9, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign guqing after the PR has been reviewed.
You can assign the PR to them by writing /assign @guqing in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

JohnNiang
JohnNiang reviewed May 9, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2022
ruibaby
ruibaby reviewed May 9, 2022
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2022
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

guqing
guqing reviewed May 9, 2022
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented May 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 607a9d3 into halo-dev:release-1.5 May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guqing guqing guqing left review comments

@ruibaby ruibaby ruibaby left review comments

@JohnNiang JohnNiang JohnNiang left review comments

@LIlGG LIlGG Awaiting requested review from LIlGG

@QuentinHsu QuentinHsu Awaiting requested review from QuentinHsu

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@halo-dev-bot @JohnNiang @ruibaby @guqing