Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the problem of without dimension information when uploading an ICO picture #1473 #1474

Merged
merged 2 commits into from
Sep 13, 2021

Conversation

Qiang156
Copy link
Contributor

@Qiang156 Qiang156 commented Sep 12, 2021

I have tried to fix bug #1473, please review.

@Qiang156 Qiang156 changed the title fixec#1473 fixed the problem of without dimension information when uploading an ICO picture #1473 Sep 12, 2021
@ruibaby ruibaby added the kind/bug Categorizes issue or PR as related to a bug. label Sep 13, 2021
@ruibaby ruibaby added this to the 1.4.12 milestone Sep 13, 2021
@guqing
Copy link
Member

guqing commented Sep 13, 2021

Please fix the code style first.

@Qiang156
Copy link
Contributor Author

Sorry, now it has been checked by CheckStyle tool.

@ruibaby ruibaby merged commit 75c8bb2 into halo-dev:master Sep 13, 2021
@ruibaby
Copy link
Member

ruibaby commented Sep 13, 2021

Thanks for your contribution!

@Qiang156 Qiang156 deleted the fixed#1473 branch September 13, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants