Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Post and sheet content is empty in the Content API #1686

Merged
merged 2 commits into from
Feb 27, 2022
Merged

fix: Post and sheet content is empty in the Content API #1686

merged 2 commits into from
Feb 27, 2022

Conversation

fuzui
Copy link
Contributor

@fuzui fuzui commented Feb 26, 2022

Fix #1685

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JohnNiang
Copy link
Member

/assign @guqing

@ruibaby
Copy link
Member

ruibaby commented Feb 26, 2022

你好 @fuzui ，感谢你的贡献。在合并之前需要 sign 一下 CLA，否则我们无法合并。#1686 (comment)

@ruibaby ruibaby added this to the 1.5.x milestone Feb 26, 2022
@ruibaby ruibaby added the kind/bug Categorizes issue or PR as related to a bug. label Feb 26, 2022
@fuzui
Copy link
Contributor Author

fuzui commented Feb 26, 2022

@ruibaby 好的。

guqing
guqing approved these changes Feb 26, 2022
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guqing
Copy link
Member

guqing commented Feb 26, 2022

hi @fuzui 修复一下 CI 使其能通过, 否则无法合并

@ruibaby
Copy link
Member

ruibaby commented Feb 26, 2022 •
edited
Loading

@fuzui 可以参考一下 https://docs.halo.run/next/developer-guide/core/code-style 文档设置代码风格检查。

@guqing
Copy link
Member

guqing commented Feb 26, 2022

这两行代码列宽超长了 配置好checkstyle后格式化一下就行
image

@fuzui
Copy link
Contributor Author

fuzui commented Feb 26, 2022

@ruibaby @guqing 抱歉，忽略了这块。感谢提醒。

@guqing
Copy link
Member

guqing commented Feb 26, 2022

/cc @halo-dev/sig-halo

JohnNiang
JohnNiang reviewed Feb 27, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @guqing ，我这里有一个小疑问，请帮忙确认一下，谢谢！

src/main/java/run/halo/app/controller/content/api/PostController.java Show resolved Hide resolved
src/main/java/run/halo/app/controller/content/api/SheetController.java Show resolved Hide resolved
JohnNiang
JohnNiang approved these changes Feb 27, 2022
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnNiang JohnNiang merged commit 5064837 into halo-dev:master Feb 27, 2022
winar-jin pushed a commit to winar-jin/halo that referenced this pull request Mar 24, 2022
@fuzui @winar-jin
Fix the problem post and sheet contents are empty in the content API (h…
6d04d09 
…alo-dev#1686)

* fix: Post and sheet content is empty in the Content API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing approved these changes

@JohnNiang JohnNiang JohnNiang approved these changes

Assignees

@guqing guqing

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
1.5.x
Development

Successfully merging this pull request may close these issues.

Content API的post和sheet详情接口中内容为空
5 participants
@fuzui @CLAassistant @JohnNiang @ruibaby @guqing