-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Process XSS security problem of each input box in the background #1883
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Ljfanny 感谢你的贡献,但我认为此修改在现阶段并不适合添加。因为据原 issue 所说,目前属于单管理员的模式,理论上不会造成安全问题,除非管理员有意为之,但这和直接修改代码没有区别。而且在目前有部分需求是需要在文章中插入 iframe 或者 script 标签的。
目前 1.5.x 已经不再使用后端渲染 Markdown,而是直接保存前端编辑器渲染的 HTML,这是为了编辑预览和实际保存的效果一致,所以可能并不适合修改。 |
另外,在提交 PR 前,我们希望先在原 issue 进行方案讨论。 /hold |
明白您的意思,虽然目前单用户的情况下的xss注入确实不是什么大问题,但是考虑到如果博客的维护者将一些恶意脚本加进博客(或者管理者不知情的情况下引入),也有可能对正常的访客造成影响。 确实考虑到一些用户有在正文里插入一些标签的需求,可以考虑对markdown语法的输入框不做处理,只对其他的输入框做处理,比如文章标题等。 |
由于 1.x 的版本已经进入维护阶段,不会添加新功能,并且此 PR 也已经不适用于 2.x,所以我将关闭此 PR。 再次感谢你的贡献。 /close |
@ruibaby: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does?
fix #1557
Mechanism
Problem