Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refine i18n for uc #4957

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Nov 30, 2023

What type of PR is this?

/area console
/kind improvement
/milestone 2.11.x

What this PR does / why we need it:

完善个人中心相关页面的 i18n。

Special notes for your reviewer:

测试各个语言的个人中心相关页面。

Does this PR introduce a user-facing change?

完善个人中心相关页面的 i18n。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 30, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.11.x milestone Nov 30, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a84f55) 56.10% compared to head (4465eea) 56.10%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4957   +/-   ##
=========================================
  Coverage     56.10%   56.10%           
  Complexity     3031     3031           
=========================================
  Files           524      524           
  Lines         17652    17652           
  Branches       1315     1315           
=========================================
  Hits           9903     9903           
  Misses         7201     7201           
  Partials        548      548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

经测试个人中心页面翻译表现正常

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

image

Copy link

f2c-ci-robot bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 5e76da0 into halo-dev:main Nov 30, 2023
4 checks passed
@ruibaby ruibaby deleted the feat/refine-uc-i18n branch November 30, 2023 10:57
ruibaby added a commit to ruibaby/halo that referenced this pull request Nov 30, 2023
#### What type of PR is this?

/area console
/kind improvement
/milestone 2.11.x

#### What this PR does / why we need it:

完善个人中心相关页面的 i18n。

#### Special notes for your reviewer:

测试各个语言的个人中心相关页面。

#### Does this PR introduce a user-facing change?

```release-note
完善个人中心相关页面的 i18n。
```
@ruibaby ruibaby modified the milestones: 2.11.x, 2.11.0 Dec 1, 2023
f2c-ci-robot bot pushed a commit that referenced this pull request Jan 13, 2024
#### What type of PR is this?

/area console
/kind bug
/milestone 2.12.x

#### What this PR does / why we need it:

取消对 es.yaml 的注释,这应该是在 #4957 中临时注释之后,合并前没有取消注释。

#### Does this PR introduce a user-facing change?

```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants