Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update links in preset post #5258

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 27, 2024

What type of PR is this?

/area console
/kind improvement
/milestone 2.12.x

What this PR does / why we need it:

更新预设文章中的链接地址。

Does this PR introduce a user-facing change?

None

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. area/console Issues or PRs related to the Halo Console labels Jan 27, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Jan 27, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jan 27, 2024
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1be470a) 57.07% compared to head (4700eec) 57.07%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5258   +/-   ##
=========================================
  Coverage     57.07%   57.07%           
  Complexity     3327     3327           
=========================================
  Files           587      587           
  Lines         18958    18958           
  Branches       1400     1400           
=========================================
  Hits          10821    10821           
  Misses         7558     7558           
  Partials        579      579           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Jan 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 3bb81d8 into halo-dev:main Jan 27, 2024
7 checks passed
@ruibaby ruibaby deleted the chore/update-preset-post branch January 27, 2024 14:43
@JohnNiang JohnNiang modified the milestones: 2.12.x, 2.12.0 Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants