Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for fetching replies alongside comment list #5505

Merged
merged 1 commit into from
Mar 16, 2024
Merged

feat: add support for fetching replies alongside comment list #5505

merged 1 commit into from
Mar 16, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Mar 13, 2024 •
edited
Loading

What type of PR is this?

/kind feature
/area core
/milestone 2.14.x
/kind api-change

What this PR does / why we need it:

主题端评论列表支持同时获得回复数据

Resolves #5435

Does this PR introduce a user-facing change?

主题端评论列表支持同时获得回复数据

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 13, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.14.x milestone Mar 13, 2024
@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Mar 13, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Mar 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 56.51%. Comparing base (5fdf6c0) to head (0f31cbc).
Report is 62 commits behind head on main.

Files Patch % Lines
...me/finders/impl/CommentPublicQueryServiceImpl.java 0.00% 11 Missing ⚠️
.../halo/app/theme/finders/vo/CommentWithReplyVo.java 0.00% 7 Missing ⚠️
...halo/app/theme/endpoint/CommentFinderEndpoint.java 40.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #5505      +/-   ##
============================================
- Coverage     56.91%   56.51%   -0.40%     
+ Complexity     3319     3312       -7     
============================================
  Files           587      592       +5     
  Lines         18968    19195     +227     
  Branches       1401     1361      -40     
============================================
+ Hits          10795    10848      +53     
- Misses         7594     7781     +187     
+ Partials        579      566      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JohnNiang
JohnNiang reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

application/src/main/java/run/halo/app/theme/finders/vo/CommentWithReplyVo.java Show resolved Hide resolved
@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
JohnNiang
JohnNiang approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 5e073bf into halo-dev:main Mar 16, 2024
8 checks passed
@guqing guqing deleted the feature/comment-with-replies branch March 16, 2024 17:22
@ruibaby ruibaby modified the milestones: 2.14.x, 2.14.0 Mar 17, 2024
@ruibaby ruibaby mentioned this pull request Mar 17, 2024
Closed
@guqing guqing mentioned this pull request Mar 18, 2024
Merged
f2c-ci-robot bot pushed a commit that referenced this pull request Mar 18, 2024
@guqing
fix: sequence inconsistency in the comment list on the theme side (#5524
cb9c3ee 
)

#### What type of PR is this?
/kind bug
/area core
/milestone 2.14.x

#### What this PR does / why we need it:
修复主题测评论列表顺序不一致的问题

此问题由 #5505 导致,开启了同时返回回复后,评论列表的顺序出现问题

#### Does this PR introduce a user-facing change?
```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

关于评论显示的建议
3 participants
@guqing @JohnNiang @ruibaby