fix: incorrect column width calculation after merging cells in the table #5803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
kind/bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5803 +/- ##
============================================
- Coverage 56.91% 56.40% -0.51%
- Complexity 3319 3449 +130
============================================
Files 587 612 +25
Lines 18968 20442 +1474
Branches 1401 1411 +10
============================================
+ Hits 10795 11531 +736
- Misses 7594 8333 +739
+ Partials 579 578 -1 ☔ View full report in Codecov by Sentry. |
LIlGG
changed the title
f2c-ci-robot
bot
added
do-not-merge/work-in-progress
f2c-ci-robot
bot
removed
the
needs-rebase
LIlGG
force-pushed
the
fix/merge-cell-table-col
branch
from
38cb08d
to
b484764
Compare
|
/retitle fix: incorrect column width calculation after merging cells in the table |
f2c-ci-robot
bot
changed the title
f2c-ci-robot
bot
removed
the
do-not-merge/work-in-progress
|
guqing
approved these changes
May 16, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/area editor
/milestone 2.16.x
What this PR does / why we need it:
默认编辑器中的表格首行被合并单元格之后，将会出现当前表在刷新之后宽度被重置为默认。此 PR 改正了计算宽度，使其首次刷新时，也能返回正确的数组。
How to test it?
Which issue(s) this PR fixes:
Fixes #5767
Does this PR introduce a user-facing change?