Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an API to invalidate theme template cache #5906

Merged
merged 2 commits into from
May 16, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented May 13, 2024

What type of PR is this?

/kind feature
/area core
/area theme
/milestone 2.16.x

What this PR does / why we need it:

为主题管理增加在线清理缓存功能

Which issue(s) this PR fixes:

Fixes #5440

Does this PR introduce a user-facing change?

为主题管理增加清理模板引擎缓存的功能。

@f2c-ci-robot f2c-ci-robot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 13, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 13, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label May 13, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen May 13, 2024 09:34
@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core area/theme Issues or PRs related to the Theme Provider labels May 13, 2024
@guqing
Copy link
Member Author

guqing commented May 13, 2024

@ruibaby 帮忙在 Console 主题管理增加一个清理缓存按钮

Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby ruibaby marked this pull request as ready for review May 14, 2024 07:26
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2024
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 56.52%. Comparing base (5fdf6c0) to head (fb0b506).
Report is 169 commits behind head on main.

Files Patch % Lines
...n/halo/app/core/extension/theme/ThemeEndpoint.java 73.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5906      +/-   ##
============================================
- Coverage     56.91%   56.52%   -0.39%     
- Complexity     3319     3463     +144     
============================================
  Files           587      612      +25     
  Lines         18968    20488    +1520     
  Branches       1401     1413      +12     
============================================
+ Hits          10795    11581     +786     
- Misses         7594     8326     +732     
- Partials        579      581       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit f24b08c into halo-dev:main May 16, 2024
8 checks passed
@guqing guqing deleted the feature/5440 branch May 16, 2024 04:40
@ruibaby ruibaby modified the milestones: 2.16.x, 2.16.0 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core area/theme Issues or PRs related to the Theme Provider kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
3 participants