Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove close button for reserved alert in role detail page #5909

Merged
merged 2 commits into from
May 14, 2024

Conversation

lan-yonghui
Copy link
Contributor

@lan-yonghui lan-yonghui commented May 13, 2024

What type of PR is this?

/kind bug
/area core
/area ui

What this PR does / why we need it:

用户角色详情页面,权限设置提示框关闭按钮不能关闭,增加对应关闭事件!
image

Does this PR introduce a user-facing change?

优化角色详情中的提示组件,移除关闭按钮。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/core Issues or PRs related to the Halo Core area/ui Issues or PRs related to the Halo UI labels May 13, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and LIlGG May 13, 2024 12:24
Copy link

f2c-ci-robot bot commented May 13, 2024

@lan-yonghui: The label(s) kind/fix cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind fix
/area core
/area ui

What this PR does / why we need it:

用户角色详情页面,权限设置提示框关闭按钮不能关闭,增加对应关闭事件!
image

Does this PR introduce a user-facing change?

用户-角色设置-权限设置提示框关闭按钮

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.51%. Comparing base (5fdf6c0) to head (36d6107).
Report is 164 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5909      +/-   ##
============================================
- Coverage     56.91%   56.51%   -0.40%     
- Complexity     3319     3462     +143     
============================================
  Files           587      612      +25     
  Lines         18968    20473    +1505     
  Branches       1401     1413      +12     
============================================
+ Hits          10795    11570     +775     
- Misses         7594     8322     +728     
- Partials        579      581       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lan-yonghui lan-yonghui changed the title fix: Fix role detail alert component close error fix: The role details alert component sets the closable attribute to false by default May 14, 2024
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ruibaby ruibaby changed the title fix: The role details alert component sets the closable attribute to false by default fix: remove close button for reserved alert in role detail page May 14, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
Copy link

f2c-ci-robot bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby ruibaby added this to the 2.16.x milestone May 14, 2024
@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 587dafa into halo-dev:main May 14, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.16.x, 2.16.0 May 16, 2024
@lan-yonghui lan-yonghui deleted the fix-role-detail branch May 17, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core area/ui Issues or PRs related to the Halo UI lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants