Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add title slot to alert component #5911

Merged
merged 1 commit into from
May 14, 2024

Conversation

lan-yonghui
Copy link
Contributor

@lan-yonghui lan-yonghui commented May 13, 2024

What type of PR is this?

/kind feature
/area core
/area ui

What this PR does / why we need it:

alert 组件增加标题插槽,可以更好的自定义标题内容!

Does this PR introduce a user-facing change?

为 VAlert 组件增加标题插槽

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels May 13, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wzrove May 13, 2024 12:33
@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core area/ui Issues or PRs related to the Halo UI labels May 13, 2024
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.51%. Comparing base (5fdf6c0) to head (acea5ce).
Report is 164 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5911      +/-   ##
============================================
- Coverage     56.91%   56.51%   -0.40%     
- Complexity     3319     3462     +143     
============================================
  Files           587      612      +25     
  Lines         18968    20473    +1505     
  Branches       1401     1413      +12     
============================================
+ Hits          10795    11570     +775     
- Misses         7594     8322     +728     
- Partials        579      581       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
Copy link

f2c-ci-robot bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit d7b6552 into halo-dev:main May 14, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.16.x, 2.16.0 May 14, 2024
@lan-yonghui lan-yonghui deleted the feat-alert-component branch May 17, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants