-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore includeSubdomains for hsts header #5956
Ignore includeSubdomains for hsts header #5956
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5956 +/- ##
============================================
- Coverage 56.91% 56.83% -0.08%
- Complexity 3319 3498 +179
============================================
Files 587 612 +25
Lines 18968 20555 +1587
Branches 1401 1420 +19
============================================
+ Hits 10795 11682 +887
- Misses 7594 8293 +699
- Partials 579 580 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/area core
/milestone 2.16.x
What this PR does / why we need it:
This PR ignores
includeSubdomains
for HSTS header. See #4943 for more.Which issue(s) this PR fixes:
Fixes #4943
Does this PR introduce a user-facing change?