Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore includeSubdomains for hsts header #5956

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind improvement
/area core
/milestone 2.16.x

What this PR does / why we need it:

This PR ignores includeSubdomains for HSTS header. See #4943 for more.

Which issue(s) this PR fixes:

Fixes #4943

Does this PR introduce a user-facing change?

修复开启 HSTS 可能会导致未开启 HSTS 的子域名站点无法访问的问题

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 21, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 21, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG May 21, 2024 03:18
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label May 21, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wan92hen May 21, 2024 03:18
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.83%. Comparing base (5fdf6c0) to head (960ce60).
Report is 182 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5956      +/-   ##
============================================
- Coverage     56.91%   56.83%   -0.08%     
- Complexity     3319     3498     +179     
============================================
  Files           587      612      +25     
  Lines         18968    20555    +1587     
  Branches       1401     1420      +19     
============================================
+ Hits          10795    11682     +887     
- Misses         7594     8293     +699     
- Partials        579      580       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
Copy link

f2c-ci-robot bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 2feaa20 into halo-dev:main May 21, 2024
8 checks passed
@JohnNiang JohnNiang deleted the bug/not-include-subdomains-for-hsts-header branch May 21, 2024 04:23
@ruibaby ruibaby modified the milestones: 2.16.x, 2.16.0 May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Halo默认开启HSTS导致未设置SSL证书的其他二级域名无法正常访问
3 participants