Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump up vue-related version #5965

Merged
merged 1 commit into from
May 22, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented May 22, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.16.x

What this PR does / why we need it:

升级 Vue 生态的相关依赖,以及修复编译 packages 时的异常日志问题。

Does this PR introduce a user-facing change?

升级 Vue 生态的相关依赖至最新版本。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels May 22, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 22, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label May 22, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from lan-yonghui and wzrove May 22, 2024 04:09
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.76%. Comparing base (5fdf6c0) to head (e694cb0).
Report is 187 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5965      +/-   ##
============================================
- Coverage     56.91%   56.76%   -0.15%     
- Complexity     3319     3486     +167     
============================================
  Files           587      611      +24     
  Lines         18968    20523    +1555     
  Branches       1401     1419      +18     
============================================
+ Hits          10795    11650     +855     
- Misses         7594     8293     +699     
- Partials        579      580       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby ruibaby requested review from JohnNiang, LIlGG and guqing and removed request for lan-yonghui and wzrove May 22, 2024 08:54
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit ce5757a into halo-dev:main May 22, 2024
8 checks passed
@ruibaby ruibaby deleted the chore/bump-vue-related-version branch May 22, 2024 15:02
@ruibaby ruibaby modified the milestones: 2.16.x, 2.16.0 May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants