Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: provide post content retrieval bean for plugins #5981

Merged
merged 1 commit into from
May 24, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented May 24, 2024

What type of PR is this?

/kind improvement
/area core
/area plugin
/milestone 2.16.x

What this PR does / why we need it:

为插件提供文章内容获取的 bean 以简化文章内容获取

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?

为插件提供文章内容获取的 Bean

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels May 24, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 24, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from ruibaby May 24, 2024 04:03
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label May 24, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wan92hen May 24, 2024 04:03
@f2c-ci-robot f2c-ci-robot bot added the area/plugin Issues or PRs related to the Plugin Provider label May 24, 2024
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 56.64%. Comparing base (5fdf6c0) to head (4c80d22).
Report is 202 commits behind head on main.

Files Patch % Lines
...a/run/halo/app/content/PostContentServiceImpl.java 16.66% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5981      +/-   ##
============================================
- Coverage     56.91%   56.64%   -0.27%     
- Complexity     3319     3477     +158     
============================================
  Files           587      612      +25     
  Lines         18968    20543    +1575     
  Branches       1401     1419      +18     
============================================
+ Hits          10795    11636     +841     
- Misses         7594     8329     +735     
+ Partials        579      578       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2024
Copy link

f2c-ci-robot bot commented May 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit cb21385 into halo-dev:main May 24, 2024
8 checks passed
@JohnNiang JohnNiang modified the milestones: 2.16.x, 2.16.0 May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core area/plugin Issues or PRs related to the Plugin Provider kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants