Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve code base of role-related #5984

Merged
merged 1 commit into from
May 24, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented May 24, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.16.x

What this PR does / why we need it:

优化和角色相关的对话框显示逻辑,减少不必要的渲染开销和请求。

Does this PR introduce a user-facing change?

优化和角色相关的对话框显示逻辑,减少不必要的渲染开销和请求。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 24, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 24, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label May 24, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and QuentinHsu May 24, 2024 06:33
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.36%. Comparing base (5fdf6c0) to head (f4a1b81).
Report is 203 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5984      +/-   ##
============================================
- Coverage     56.91%   56.36%   -0.55%     
- Complexity     3319     3506     +187     
============================================
  Files           587      615      +28     
  Lines         18968    20714    +1746     
  Branches       1401     1441      +40     
============================================
+ Hits          10795    11675     +880     
- Misses         7594     8457     +863     
- Partials        579      582       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented May 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 769b19c into halo-dev:main May 24, 2024
8 checks passed
@JohnNiang JohnNiang modified the milestones: 2.16.x, 2.16.0 May 24, 2024
@ruibaby ruibaby deleted the refactor/role-related-modal branch May 24, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants