Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: record the plugin query conditions in the route query parameters #5995

Merged
merged 1 commit into from
May 27, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented May 27, 2024

What type of PR is this?

/area ui
/kind feature
/milestone 2.16.x

What this PR does / why we need it:

在插件数据管理列表页面路由中记录查询条件,可以保证在刷新页面或者切换路由返回时保留之前的查询状态。

image

Special notes for your reviewer:

需要测试:

  1. 插件管理列表的所有筛选项是否可以正常工作。
  2. 尝试设置部分筛选,然后刷新页面,观察筛选条件是否正常保留。

Does this PR introduce a user-facing change?

Console 端的插件管理列表支持在地址栏记录筛选条件。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels May 27, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 27, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from lan-yonghui May 27, 2024 04:07
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label May 27, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wan92hen May 27, 2024 04:07
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.24%. Comparing base (5fdf6c0) to head (3dbf67e).
Report is 207 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5995      +/-   ##
============================================
- Coverage     56.91%   56.24%   -0.68%     
- Complexity     3319     3497     +178     
============================================
  Files           587      616      +29     
  Lines         18968    20734    +1766     
  Branches       1401     1441      +40     
============================================
+ Hits          10795    11661     +866     
- Misses         7594     8493     +899     
- Partials        579      580       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 19fb1c2 into halo-dev:main May 27, 2024
8 checks passed
@ruibaby ruibaby deleted the feat/store-plugin-query-params branch May 27, 2024 08:29
@JohnNiang JohnNiang modified the milestones: 2.16.x, 2.16.0 May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants