Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable asynchronous resolving for UI extension points #6018

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented May 30, 2024

What type of PR is this?

/area ui
/kind feature
/milestone 2.16.x

What this PR does / why we need it:

优化 UI 部分的扩展点获取实现,让部分扩展点支持异步获取,之前的实现与文档不符。

比如:

import { definePlugin } from "@halo-dev/console-shared";
import axios from "axios";

export default definePlugin({
  components: {},
  routes: [],
  extensionPoints: {
    "attachment:selector:create": async () => {
      const { data } = await axios.get(
        "/apis/v1alpha1/fake.halo.run/attachments/selectors"
      );

      return data;
    },
  },
});

Which issue(s) this PR fixes:

Fixes #6008

Does this PR introduce a user-facing change?

优化 UI 部分的扩展点获取实现,让部分扩展点支持异步获取。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels May 30, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 30, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from Aanko May 30, 2024 03:03
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label May 30, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wzrove May 30, 2024 03:03
Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ruibaby ruibaby requested review from JohnNiang, LIlGG and guqing and removed request for Aanko and wzrove May 30, 2024 03:10
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.13%. Comparing base (5fdf6c0) to head (174daea).
Report is 216 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6018      +/-   ##
============================================
- Coverage     56.91%   56.13%   -0.78%     
- Complexity     3319     3515     +196     
============================================
  Files           587      621      +34     
  Lines         18968    20915    +1947     
  Branches       1401     1460      +59     
============================================
+ Hits          10795    11740     +945     
- Misses         7594     8582     +988     
- Partials        579      593      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 4c6abdc into halo-dev:main May 30, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.16.x, 2.16.0 May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

为 Console 端的扩展点获取添加异步支持
3 participants