-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the problem that theme assets could not be found after the first initialization #6049
Fix the problem that theme assets could not be found after the first initialization #6049
Conversation
…initialization Signed-off-by: JohnNiang <johnniang@foxmail.com>
/cherrypick release-2.16 |
@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6049 +/- ##
============================================
- Coverage 56.91% 56.47% -0.44%
- Complexity 3319 3541 +222
============================================
Files 587 622 +35
Lines 18968 20957 +1989
Branches 1401 1478 +77
============================================
+ Hits 10795 11836 +1041
- Misses 7594 8521 +927
- Partials 579 600 +21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JohnNiang: new pull request created: #6050 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
/area core
/milestone 2.17.x
What this PR does / why we need it:
When initialized for the first time, the folder
${halo.work-dir}/themes
does not exist, resulting in thethemes
path being ignored when invokingthemeRootResource.createRelative(themeName + "/templates/assets/");
. It works very well after restarting.This PR fixes the problem by resolving theme resource directly rather than delegating to PathResourceResolver.
Which issue(s) this PR fixes:
Fixes #6048
Does this PR introduce a user-facing change?