Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat&bug: fix issue 763 #834

Merged
merged 1 commit into from
Aug 6, 2020
Merged

feat&bug: fix issue 763 #834

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/main/java/run/halo/app/service/impl/BasePostServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,16 @@ public void increaseVisit(long visits, Integer postId) {
Assert.isTrue(visits > 0, "Visits to increase must not be less than 1");
Assert.notNull(postId, "Post id must not be null");

long affectedRows = basePostRepository.updateVisit(visits, postId);
boolean finishedIncrease;
if (basePostRepository.getByIdAndStatus(postId, PostStatus.DRAFT).isPresent())
{
finishedIncrease = true;
log.info("Post with id: [{}] is a draft and visits will not be updated", postId);
} else {
finishedIncrease = basePostRepository.updateVisit(visits, postId) == 1;
}

if (affectedRows != 1) {
if (!finishedIncrease) {
log.error("Post with id: [{}] may not be found", postId);
throw new BadRequestException("Failed to increase visits " + visits + " for post with id " + postId);
}
Expand Down