feat: add custom initialisms support to gen package and avrogen #303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this simple PR adds support for custom initialisms to the
gen
package andavrogen
command.Additional custom initialisms are necessary because
strcase.ToGoPascal
only uses GoLint's list of initialisms.Currently, if an initialism in struct/field names is not part of Golint's, then
strcase
wrongly downcases it.For example, consider the following schema containing the domain initialism
AID
:Currently,
avrogen
generates the following Go struct (struct/field names:AID
->Aid
):With this PR,
-initialisms AID
can be given toavrogen
to generate the correct struct/field names:There is a related PR in the upstream
strcase
repository: ettle/strcase#13That PR allows to preserve any extra initialisms without having to define them in advance, however the maintainers seems to not be merging it any time soon. This PR allows to solve the issue in the mean time.