Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): add fragment and instance back to container props #1399

Merged
merged 1 commit into from
Sep 21, 2020
Merged

fix(ecs): add fragment and instance back to container props #1399

merged 1 commit into from
Sep 21, 2020

Conversation

roleyfoley
Copy link
Contributor

Description

Minor regression fix to align the changes in #1388 with the changes added in #1396

Motivation and Context

New attributes added in one PR that wern't covered in a PR to move the container configuration to a new location

How Has This Been Tested?

Tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves the structure or operation of the implementation)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Followup Actions

  • None

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • None of the above.

@roleyfoley roleyfoley requested a review from a team September 21, 2020 09:30
@roleyfoley roleyfoley merged commit c146906 into hamlet-io:master Sep 21, 2020
@roleyfoley roleyfoley deleted the fix-container-regression branch September 21, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant