-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecs container advanced configuration #1396
Conversation
@@ -2,6 +2,11 @@ | |||
|
|||
[#assign | |||
containerChildrenConfiguration = [ | |||
{ | |||
"Names" : ["Fragment", "Container"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AS this is new, reckon we drop the legacy name and just support "Fragment"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks fine
Description
Adds a collection of changes for ECS to allow for advanced configurations
This also adds support for docker in docker when running Jenkins agents. While not always a recommend approach this PR covers off most of the concerns outlined in http://jpetazzo.github.io/2015/09/03/do-not-use-docker-in-docker-for-ci/
Motivation and Context
These changes have primarily been focussed on introducing the features required to make docker in docker work nicely on an ECS cluster for Jenkins agent hosting
How Has This Been Tested?
Tested on codepublican testing environment
Types of changes
Followup Actions
Checklist: