-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Domain Qualificiation failing #1599
Labels
Comments
Workaround in place to disable qualification on input processing With @ml019 to fix the issue that both name and Id are used in the current qualification process but don't appear to be followed in the current input processing |
PR #1600 is the workaround to revert qualification |
With @ml019 |
ml019
added a commit
to ml019/engine
that referenced
this issue
May 30, 2021
Re-enable qualification Fixes hamlet-io#1599 Reverses PR hamlet-io#1600 For backwards compatability, ensure input qualification checks for ids and names of layers. Best practice should be to encourage the use of names and long form qualification but a number of existing cmdbs use ids and short form qualifiers. This PR also adds some longer form alternatives for the `info` and `warn` macros, as well as an alternative `fatal` macro which always stops processing. A followup PR will remove the use of specific checks for qualification via the segmentQualifiers global variable.
ml019
added a commit
to ml019/engine
that referenced
this issue
Jun 9, 2021
Re-enable qualification Fixes hamlet-io#1599 Reverses PR hamlet-io#1600 For backwards compatability, ensure input qualification checks for ids and names of layers. Best practice should be to encourage the use of names and long form qualification but a number of existing cmdbs use ids and short form qualifiers. This PR also adds some longer form alternatives for the `info` and `warn` macros, as well as an alternative `fatal` macro which always stops processing. A followup PR will remove the use of specific checks for qualification via the segmentQualifiers global variable.
roleyfoley
pushed a commit
that referenced
this issue
Jun 10, 2021
* feat: input qualification Re-enable qualification Fixes #1599 Reverses PR #1600 For backwards compatability, ensure input qualification checks for ids and names of layers. Best practice should be to encourage the use of names and long form qualification but a number of existing cmdbs use ids and short form qualifiers. This PR also adds some longer form alternatives for the `info` and `warn` macros, as well as an alternative `fatal` macro which always stops processing. A followup PR will remove the use of specific checks for qualification via the segmentQualifiers global variable. * refactor: Capture qualification outcomes Add an annotated copy of the state to the inputState showing which qualifiers were or weren't applied. This is intended to form the basis of tooling to assist users determine the effect of the provided qualifiers where the results produced are unexpected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Behaviour
When processing a component which uses domain names and one of the domains have qualification enabled this appears to be ignored and the unqualified domains is returned
Expected Behaviour
The domain that has been configured through qualification should be returned
Possible Solution
Steps to Reproduce
The expected result is
parks.exmaple.org
the current result isecommerce.np.cp1.parks.example.org
The text was updated successfully, but these errors were encountered: