-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Engine (ROM) #334
New Engine (ROM) #334
Changes from 65 commits
f7caaa2
33f8454
34ee062
26af58f
eb0bab7
0f2df19
00c0c11
26c17eb
6ea119e
b4d7907
c79ed48
1827a7b
eeee2e2
fce2f84
19f17b3
98756d7
94535c2
ed973e5
36e8cf3
f97a69f
3ac7c2f
8170484
a6a46b3
ab15107
9713f7a
d489c9f
8982a2f
5b2fd46
4d2db84
d25eda4
0a85c15
ae85fca
ab67662
c02e915
9d048bf
14b4f24
ef4ccd7
e52d904
1a53218
5cf7279
0d3312e
e43361d
e7cb707
00151bd
a9c3c40
ef1d8f3
5c01ca2
9f111a4
eedff4f
6faec06
a196a4e
c3b25de
7920259
a0702bd
ec3aeed
1c205eb
480d1f4
ef50623
cc3067b
db8355f
97a241e
af211f3
cb61437
998282e
be5ee9a
911bfc5
0ddf6e6
dce6111
7ce7620
af05f69
bf4f270
3d45c41
5b62a8f
49ea150
813bcc1
b5300be
3963306
cb59e7e
c9440d4
4ad9db6
9a2b3ee
419712c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
AllCops: | ||
DisplayCopNames: true | ||
DisplayStyleGuide: true | ||
ExtraDetails: false | ||
Style/PredicateName: | ||
Enabled: false | ||
Lint/HandleExceptions: | ||
Enabled: false | ||
Lint/IneffectiveAccessModifier: | ||
Enabled: false | ||
Lint/AssignmentInCondition: | ||
Enabled: false | ||
Style/RaiseArgs: | ||
Enabled: false | ||
Style/MethodMissing: | ||
Enabled: false | ||
Style/RegexpLiteral: | ||
Enabled: false | ||
Style/FileName: | ||
Enabled: false | ||
Metrics/LineLength: | ||
Enabled: false | ||
Style/GuardClause: | ||
Enabled: false |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,17 @@ | ||
language: ruby | ||
sudo: false | ||
cache: bundler | ||
script: 'bundle exec rake test:coverage --trace' | ||
script: 'bundle exec rubocop && bundle exec rake test:coverage --trace' | ||
after_script: 'echo `env`' | ||
rvm: | ||
- 2.2.5 | ||
- 2.3.1 | ||
- jruby-9.0.5.0 | ||
- ruby-head | ||
- jruby-head | ||
env: | ||
- DB=sqlite | ||
- DB=postgresql | ||
- DB=mysql | ||
|
||
addons: | ||
postgresql: '9.4' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI, we could add 9.5, if we want to use Travis's There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @cllns I prefer to avoid beta Travis CI features for now. Too moving parts. |
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,8 +2,32 @@ | |
A persistence layer for Hanami | ||
|
||
## v0.7.0 - (unreleased) | ||
### Added | ||
- [Luca Guidi] Experimental support for One-To-Many association (aka `has_many`) | ||
- [Luca Guidi] Native support for PostgreSQL types like UUID, Array, JSON(B) and Money | ||
- [Luca Guidi] Repositories instances can access all the relations (eg. `BookRepository` can access `users` relation via `#users`) | ||
- [Luca Guidi] Automapping for SQL databases | ||
- [Luca Guidi] Added `Hanami::Model::DatabaseError` | ||
|
||
### Changed | ||
– [Luca Guidi] Drop support for Ruby 2.0 and 2.1 | ||
- [Luca Guidi] Removed `.attributes` from entity | ||
- [Luca Guidi] Removed `#fetch`, `#execute` and `#transaction` from repository | ||
- [Luca Guidi] Removed `mapping` block from `Hanami::Model.configure` | ||
- [Luca Guidi] Changed `adapter` signature in `Hanami::Model.configure` (use `adapter :sql, ENV['DATABASE_URL']`) | ||
- [Luca Guidi] Repositories must inherit from `Hanami::Repository` instead of including it | ||
- [Pascal Betz] Repositories use instance level interface (eg. `BookRepository.new.find` instead of `BookRepository.find`) | ||
- [Luca Guidi] Repositories now work can accept hash for CRUD operations | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Repositories now accept hashes for CRUD operations" |
||
- [Luca Guidi] `Hanami::Repository#create` now accepts: and data (or entity) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "data hash" instead of "and data"? |
||
- [Luca Guidi] `Hanami::Repository#update` now accepts two arguments: primary key (`id`) and data (or entity) | ||
- [Luca Guidi] `Hanami::Repository#delete` now accepts: primary key (`id`) | ||
- [Luca Guidi] Drop `Hanami::Model::NonPersistedEntityError`, `Hanami::Model::InvalidMappingError`, `Hanami::Model::InvalidCommandError`, `Hanami::Model::InvalidQueryError` | ||
- [Luca Guidi] Official support for Ruby 2.3 and JRuby 9.0.5.0 | ||
- [Luca Guidi] Drop support for Ruby 2.0, 2.1, 2.2, and JRuby 9.0.0.0 | ||
- [Luca Guidi] Drop support for `mysql` gem in favor of `mysql2` | ||
|
||
### Fixed | ||
- [Luca Guidi] Ensure booleans to be correctly dumped in database | ||
- [Luca Guidi] Ensure to respect default schema values | ||
|
||
## v0.6.2 - 2016-06-01 | ||
### Changed | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we setup https://houndci.com/ (or similar) instead of running rubocop here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to see we're using rubocop btw :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cllns For now I'd keep things simple and avoid yet another dep. Things may change after 1.0. 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC consensus finally shifted to using HoundCI – should this be reverted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@beauby Not yet. I just activated HoundCI for this project. From the next PR we can revert this diff change.