-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using @partial-block twice in a template not possible #1252
Comments
I can confirm that it works with 4.0.3 and 4.0.4, but not in 4.0.5 and 4.0.6 |
The following functions are called before the exception occurs: With the template being
The last invocation has |
This fix treats partial-blocks more like closures and uses the closure-context of the "invokePartial"-function to store the @partial-block for the partial.
Fixes #1252 - This fix treats partial-blocks more like closures and uses the closure-context of the "invokePartial"-function to store the @partial-block for the partial. - Adds a tes for the fix
Nice to hear, thanks @nknapp! Any ideas when the next version containing this will ship? |
I can't do that myself (I don't have publish rights for Handlebars on the various registries). I'll open an issue for that. |
I discovered that my issue with #1185 is caused by including the
@partial-block
twice inside a template like this:template.hbs
demo.hbs
Currently no possibility to check, but haven't touched the code and with with v4.0.3 it seemed to work, however after commit 7535e48 it produces the following console output:
/cc @lawnsea
The text was updated successfully, but these errors were encountered: