Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing #1673 #1674

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Fixing #1673 #1674

merged 2 commits into from
Apr 3, 2020

Conversation

ErisDS
Copy link
Collaborator

@ErisDS ErisDS commented Apr 3, 2020

Note, I've deliberately commented out a bunch of tests just to make it a little easier to see what is failing

  • added a test to demonstrate the regression
  • use duplicate-arguments-array, which correctly handles --amd --no-amd
  • unfortunately this breaks all other valid multi-keys like -k for known helpers :(

@ErisDS ErisDS changed the title Attempt to fix #1673 [Failed] Attempt to fix #1673 Apr 3, 2020
@ErisDS ErisDS mentioned this pull request Apr 3, 2020
Closed
@ErisDS
tests: added failing test for issue handlebars-lang#1673
0adc63d 
- demonstrates the regression
@ErisDS
chore: bumping yargs to v15
b9e905b 
fixes handlebars-lang#1673

- we no longer need to pin to yargs 14 for node 6 & 8 support
@ErisDS ErisDS changed the title [Failed] Attempt to fix #1673 Fixing #1673 Apr 3, 2020
@ErisDS ErisDS merged commit 8727d20 into handlebars-lang:master Apr 3, 2020
@ErisDS ErisDS deleted the issue-1673 branch April 3, 2020 20:03
This was referenced Nov 17, 2020
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ErisDS