Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the List-returning GetFirstByLowestScoreFromSet #368

Closed
shokanson-extensiv opened this issue May 24, 2024 · 3 comments
Closed

Comments

@shokanson-extensiv
Copy link
Contributor

shokanson-extensiv commented May 24, 2024

In a conversation with Sergey Odinokov regarding the new scheduler parallelism support in Hangfire.Core 1.8.12, he suggested this to allow Hangfire.PostgreSql to support it:

The method that's required to be implemented is the GetFirstByLowestScoreFromSet that returns List<string> instead of a single value, which is already implemented. This is the implementation in SqlServerConnection, and in fact, the implementation in PostgreSQL for a single value is already implemented here. So the new implementation should only change QuerySingleOrDefault to Query and remove the LIMIT clause in the query itself.

(I think the last part is incorrect because the LIMIT clause should remain, but instead of 1 use the provided count.)

I have made the changes in a local repo and would like to submit a PR for review. Should I fork this GitHub repo and submit a PR from my fork? Or should I push a feature branch to this repo and submit the PR from there?

@azygis
Copy link
Collaborator

azygis commented May 24, 2024

You cannot push to this repo directly while not being a collaborator/member. Please create a PR from a fork.

shokanson-extensiv pushed a commit to shokanson-extensiv/Hangfire.PostgreSql that referenced this issue May 25, 2024
shokanson-extensiv added a commit to shokanson-extensiv/Hangfire.PostgreSql that referenced this issue May 25, 2024
shokanson-extensiv added a commit to shokanson-extensiv/Hangfire.PostgreSql that referenced this issue May 30, 2024
support non-exception-based discovery of batching capability

add HasFeature unit tests
azygis added a commit that referenced this issue Jun 27, 2024
…cheduler-parallelism

#368 allow scheduler parallelism
@azygis
Copy link
Collaborator

azygis commented Jun 27, 2024

Thank you! And sorry for the long wait.

@azygis azygis closed this as completed Jun 27, 2024
@shokanson-extensiv
Copy link
Contributor Author

No problem. Thank you for accepting my contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants