-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Hotm Features + Hotm API/Data #1059
Conversation
# Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt # src/main/java/at/hannibal2/skyhanni/config/Storage.java # src/main/java/at/hannibal2/skyhanni/utils/StringUtils.kt
This reverts commit 2ed9de7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/main/java/at/hannibal2/skyhanni/config/features/mining/HotmConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/mining/HotmConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/mining/HotmConfig.java
Outdated
Show resolved
Hide resolved
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/config/Storage.java
Conflicts have been resolved! 🎉 |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/utils/TimeLimitedCache.kt
Conflicts have been resolved! 🎉 |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look at #1564 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few code things I saw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crash on startup
Point of focus of this PR ist the Hotm API, which gives every data that could be needed from the hotm tree. The features are only there so that the PR can be test (If more detailed testing is need revert 243a4c2) and since there also useful for the user they are full features.
Preview
Changelog New Features
Changelog Technical Details