Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Hide Far Entities #1064

Merged
merged 20 commits into from
Apr 23, 2024
Merged

Feature: Hide Far Entities #1064

merged 20 commits into from
Apr 23, 2024

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Feb 26, 2024 •
edited
Loading

What

This debug feature increases my fps by 5% to 150%. Depending on the situation and value set.

Images

image

Changelog New Features

  • Added Hide Far Entities. - hannibal2
    • Can perhaps increase FPS for some users by 5% to 150%.
    • Options to change the distance and number of mobs to always show.
    • Option to disable in garden.

@hannibal002 hannibal002 added this to the Version 0.24 milestone Feb 26, 2024
CalMWolfs
CalMWolfs requested changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I feel this is good for performance I feel there still needs to be some stuff like always render if within x blocks unless you cant see it or something. If this is accidentally turned on by a user selecting turn all features on they may think it is a bug with the mod

src/main/java/at/hannibal2/skyhanni/config/features/dev/HideFarEntitiesConfig.java Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Feb 29, 2024
@hannibal002
Merge branch 'beta' into hide-far-entities
7ea210a 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
@hannibal002
changed float to int
d5ba41c
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Mar 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2024

Conflicts have been resolved! 🎉

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Mar 10, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Mar 11, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@hannibal002
Merge branch 'beta' into hide-far-entities
62757de 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Mar 11, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Mar 14, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@hannibal002
Merge branch 'beta' into hide-far-entities
6cb08f0 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Mar 14, 2024
Thunderblade73
Thunderblade73 suggested changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@Thunderblade73 Thunderblade73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So small issues. I do not like the way how ignored is obtained but I also can't find a better solution right now.

src/main/java/at/hannibal2/skyhanni/features/misc/HideFarEntities.kt Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/features/misc/HideFarEntities.kt Outdated Show resolved Hide resolved
@hannibal002
Copy link
Owner Author

@Thunderblade73 Are your objections around the calculation of ignored only how the code looks, how we technically do it, or what kind of pseudocode logic we want to use at all?

@Thunderblade73
Copy link
Contributor

It is about how we technically do it, readability is good. But let me think about, maybe I find a better solution.

@hannibal002 hannibal002 removed the Soon This Pull Request will be merged within the next couple of betas label Mar 23, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@hannibal002
Merge branch 'beta' into hide-far-entities
dc95bfa 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
@hannibal002
move
eec57e3
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Apr 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Conflicts have been resolved! 🎉

CalMWolfs
CalMWolfs requested changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current implementation of feature toggle turning all off features on, i cannot approve this

@hannibal002
Copy link
Owner Author

With the current implementation of feature toggle turning all off features on, i cannot approve this

this has changed now.

@hannibal002 hannibal002 requested a review from CalMWolfs April 22, 2024 13:28
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Apr 23, 2024
CalMWolfs
CalMWolfs approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me, doubled fps on showing all within 20 blocks and at most 50 entities, but maybe the default values are a little low

@hannibal002 hannibal002 merged commit 85b62f0 into beta Apr 23, 2024
7 checks passed
@hannibal002 hannibal002 deleted the hide-far-entities branch April 23, 2024 21:57
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalMWolfs CalMWolfs CalMWolfs approved these changes

@nea89o nea89o Awaiting requested review from nea89o

@martimavocado martimavocado Awaiting requested review from martimavocado

@Thunderblade73 Thunderblade73 Awaiting requested review from Thunderblade73

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.25
Development

Successfully merging this pull request may close these issues.
5 participants
@hannibal002 @Thunderblade73 @nea89o @martimavocado @CalMWolfs